transmission: Fix tracker issue with some firewalls

Some firewalls mandate a minimum size of 4k for SYN packets, which
transmission does not do by default. Upstream issue here:

https://github.com/transmission/transmission/issues/964

Cleanup:

Fixed license info.

Removed two unnecessary patches.

Ran shell script through shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2019-09-08 18:39:33 -07:00
parent c256e6971f
commit 730a1697fe
5 changed files with 34 additions and 83 deletions
@@ -1,26 +0,0 @@
From a2991e22434352a3114bf437674070a135b723fd Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Sun, 27 May 2018 13:38:27 -0700
Subject: [PATCH] portcheck: Switch to HTTPS
Useful for testing TLS verification.
---
libtransmission/rpcimpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libtransmission/rpcimpl.c b/libtransmission/rpcimpl.c
index 46fd3192c..dcd96df59 100644
--- a/libtransmission/rpcimpl.c
+++ b/libtransmission/rpcimpl.c
@@ -1455,7 +1455,7 @@ portTest (tr_session * session,
struct tr_rpc_idle_data * idle_data)
{
const int port = tr_sessionGetPeerPort (session);
- char * url = tr_strdup_printf ("http://portcheck.transmissionbt.com/%d", port);
+ char * url = tr_strdup_printf ("https://portcheck.transmissionbt.com/%d", port);
tr_webRun (session, url, portTested, idle_data);
tr_free (url);
return NULL;
--
2.17.0
@@ -1,28 +0,0 @@
From 81d584b9027b2b2ddd3209c1582c9ec73c26cc3e Mon Sep 17 00:00:00 2001
From: Simon Wells <simonrwells@gmail.com>
Date: Sun, 27 May 2018 13:44:41 -0700
Subject: [PATCH] Change TR_CURL_SSL_VERIFY to TR_CURL_SSL_NO_VERIFY
use secure by default and change the env var to match curl -k behaviour
Closes: #179
---
libtransmission/web.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libtransmission/web.c b/libtransmission/web.c
index 997a151b5..ce41e342a 100644
--- a/libtransmission/web.c
+++ b/libtransmission/web.c
@@ -392,7 +392,7 @@ tr_webThreadFunc (void * vsession)
web->taskLock = tr_lockNew ();
web->tasks = NULL;
web->curl_verbose = tr_env_key_exists ("TR_CURL_VERBOSE");
- web->curl_ssl_verify = tr_env_key_exists ("TR_CURL_SSL_VERIFY");
+ web->curl_ssl_verify = !tr_env_key_exists ("TR_CURL_SSL_NO_VERIFY");
web->curl_ca_bundle = tr_env_get_string ("CURL_CA_BUNDLE", NULL);
if (web->curl_ssl_verify)
{
--
2.17.0