From 578762f4fcbfc83bf62ebc10af3deac767ac7043 Mon Sep 17 00:00:00 2001 From: Sebastian Kemper Date: Wed, 19 Dec 2018 20:24:12 +0100 Subject: [PATCH 1/2] sqlite3: remove $(FPIC) Defaulting to -fPIC is a bad idea, especially for executables (here: sqlite3-cli). In short, there are certain security implications as well as overhead/performance penalties. Details see: https://wiki.gentoo.org/wiki/Project:Hardened/Position_Independent_Code_internals The configure script is able to detect the need for PIC and adds the flag when needed anyway (when compiling the library). Signed-off-by: Sebastian Kemper --- libs/sqlite3/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/sqlite3/Makefile b/libs/sqlite3/Makefile index 28020e3a2..d50b15bb5 100644 --- a/libs/sqlite3/Makefile +++ b/libs/sqlite3/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=sqlite PKG_VERSION:=3260000 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE:=$(PKG_NAME)-autoconf-$(PKG_VERSION).tar.gz PKG_HASH:=5daa6a3fb7d1e8c767cd59c4ded8da6e4b00c61d3b466d0685e35c4dd6d7bf5d @@ -75,7 +75,7 @@ $(call Package/sqlite3/Default/description) formats. endef -TARGET_CFLAGS += $(FPIC) \ +TARGET_CFLAGS += \ -DSQLITE_ENABLE_UNLOCK_NOTIFY=1 \ -DHAVE_ISNAN=1 \ -DHAVE_MALLOC_USABLE_SIZE=1 From e814c888d03d9c3914c51b37150ceec851b046eb Mon Sep 17 00:00:00 2001 From: Sebastian Kemper Date: Wed, 19 Dec 2018 20:25:50 +0100 Subject: [PATCH 2/2] sqlite3: change maintainer Signed-off-by: Sebastian Kemper --- libs/sqlite3/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/sqlite3/Makefile b/libs/sqlite3/Makefile index d50b15bb5..234369130 100644 --- a/libs/sqlite3/Makefile +++ b/libs/sqlite3/Makefile @@ -34,7 +34,7 @@ define Package/sqlite3/Default SUBMENU:=database TITLE:=SQLite (v3.x) database engine URL:=http://www.sqlite.org/ - MAINTAINER:=Etienne CHAMPETIER + MAINTAINER:=Sebastian Kemper endef define Package/sqlite3/Default/description